Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration between widgets and CKEDITOR.style #1566

Open
Comandeer opened this issue Feb 1, 2018 · 2 comments
Open

Integration between widgets and CKEDITOR.style #1566

Comandeer opened this issue Feb 1, 2018 · 2 comments
Labels
changelog:api A changelog entry should be put in the API section of the changelog. plugin:widget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone
Backlog

Comments

@Comandeer
Copy link
Member

Comandeer commented Feb 1, 2018 •
edited
Loading

Are you reporting a feature request or a bug?

Feature request

We have special class for widget styles, CKEDITOR.style.customHandlers.widget, however it doesn't contain whole functionality of basic CKEDITOR.style and it's limited only to operating on classes.

It's caused by the fact that internally it uses widget methods to apply and remove styles:

Such subclass of CKEDITOR.style should support all ways to add styles, especially inline styles.

Example: https://jsfiddle.net/qwopws2b/

  1. Focus widget.
  2. Click button without icon in the toolbar.

Only style defined by class is applied, inline styles (font size) are not added.
@Comandeer Comandeer added type:feature A feature request. status:confirmed An issue confirmed by the development team. plugin:widget The plugin which probably causes the issue. labels Feb 1, 2018
@mlewand mlewand added this to the Backlog milestone Feb 2, 2018
@mlewand
Copy link
Contributor

mlewand commented Feb 2, 2018 •
edited
Loading

This would be great addition for the upcoming Easy Image plugin (#932).

@mlewand mlewand added the target:major Any docs related issue that should be merged into a major branch. label Feb 4, 2018
@engineering-this engineering-this mentioned this issue Feb 14, 2018
Open
@mlewand mlewand added the changelog:api A changelog entry should be put in the API section of the changelog. label Feb 16, 2018
@engineering-this engineering-this mentioned this issue Mar 5, 2018
Closed
2 tasks
@engineering-this engineering-this self-assigned this Aug 31, 2018
@engineering-this
Copy link
Contributor

Self assigning to remember to clean this once we are done with #1674

@f1ames f1ames removed the target:major Any docs related issue that should be merged into a major branch. label Nov 12, 2019
@engineering-this engineering-this removed their assignment Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog:api A changelog entry should be put in the API section of the changelog. plugin:widget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@f1ames @Comandeer @mlewand @engineering-this