Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add caseSensitive option for mentions configuration #1934

Closed
jacekbogdanski opened this issue Apr 27, 2018 · 1 comment
Closed

Add caseSensitive option for mentions configuration #1934

jacekbogdanski opened this issue Apr 27, 2018 · 1 comment
Labels
changelog:skip A changelog entry should not be added for a given issue. plugin:mentions The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone
4.10.0

Comments

@jacekbogdanski
Copy link
Member

Are you reporting a feature request or a bug?

Feature request

Mentions plugin should allow for an additional configuration option i.e. caseSensitive to choose between case sensitive/insensitive simple feed matching. You can read more about this issue in mentions plugin concept: #1703 (comment).

Expected result

Optional [caseSensitive=false] option for mentions configuration object.

Actual result

mentions plugin is case sensitive by default. It's not possible to change this behavior except providing different feed.

Other details

  • Browser: any
  • OS: any
  • CKEditor version: 4.10.0
  • Installed CKEditor plugins: mentions
@jacekbogdanski jacekbogdanski added type:feature A feature request. status:confirmed An issue confirmed by the development team. plugin:mentions The plugin which probably causes the issue. labels Apr 27, 2018
@jacekbogdanski jacekbogdanski mentioned this issue Apr 27, 2018
Merged
2 tasks
@mlewand mlewand added the changelog:skip A changelog entry should not be added for a given issue. label May 8, 2018
@mlewand
Copy link
Contributor

mlewand commented May 8, 2018

Fixed in #1936.

@mlewand mlewand closed this as completed May 8, 2018
@mlewand mlewand added this to the 4.10.0 milestone May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog:skip A changelog entry should not be added for a given issue. plugin:mentions The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
4.10.0
Development

No branches or pull requests
2 participants
@mlewand @jacekbogdanski