Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid display name for links with mailto href #2027

Closed
jacekbogdanski opened this issue May 29, 2018 · 1 comment
Closed

Invalid display name for links with mailto href #2027

jacekbogdanski opened this issue May 29, 2018 · 1 comment
Assignees
@Dumluregn
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:link The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.13.1

Comments

@jacekbogdanski
Copy link
Member

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open CKEditor sample with link plugin.
  2. Add a link with display name @foo and href foo@example.com.
  3. Click on the added link to open dialog.
  4. Close dialog by clicking ok button.

linkmail

Expected result

Link shouldn't change its display name.

Actual result

Link has href as a display name.

Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: 4.9.2
  • Installed CKEditor plugins: link
@jacekbogdanski jacekbogdanski added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:link The plugin which probably causes the issue. labels May 29, 2018
@mlewand mlewand added target:minor Any docs related issue that can be merged into a master or major branch. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. and removed target:minor Any docs related issue that can be merged into a master or major branch. labels Jul 3, 2018
@Dumluregn Dumluregn self-assigned this Jul 3, 2019
@Dumluregn Dumluregn mentioned this issue Jul 5, 2019
Merged
2 tasks
@f1ames f1ames added this to the 4.13.0 milestone Sep 6, 2019
@f1ames f1ames modified the milestones: 4.13.0, Next Sep 17, 2019
@f1ames f1ames added the target:minor Any docs related issue that can be merged into a master or major branch. label Sep 26, 2019
@f1ames
Copy link
Contributor

f1ames commented Oct 2, 2019

Fixed in d4617d1.

@f1ames f1ames closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dumluregn Dumluregn

Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:link The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.13.1
Development

No branches or pull requests
4 participants
@f1ames @mlewand @jacekbogdanski @Dumluregn