Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons opening dropdown should better indicate its content with aria-haspopup property #2072

Closed
mlewand opened this issue Jun 11, 2018 · 3 comments
Closed

Buttons opening dropdown should better indicate its content with aria-haspopup property #2072

mlewand opened this issue Jun 11, 2018 · 3 comments
Labels
accessibility Issue related to accessibility. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone
4.11.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Jun 11, 2018

Type of report

Feature request

Provide description of the new feature

WAI-ARIA 1.1 has added new values for aria-haspopup property, among them are listbox and menu. This allows us to better indicate what is contained by button that has a popup.

We have some buttons that opens [role=menu] elements (e.g. menubutton) and several other that work on listboxes (e.g. style combo, color button).

Currently their buttons aria-haspopup is set to true. It should get more precise value for each case.
@mlewand mlewand added type:feature A feature request. status:confirmed An issue confirmed by the development team. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. accessibility Issue related to accessibility. target:major Any docs related issue that should be merged into a major branch. labels Jun 11, 2018
@mlewand mlewand added this to the Backlog milestone Jun 11, 2018
@mlewand
Copy link
Contributor Author

mlewand commented Jun 11, 2018

One important thing is to ensure that our official a11y environment works correctly with this change. We don't want to break a11y support in case if JAWS did not caught up with WAI-ARIA 1.1 and treats [aria-haspopup=listbox] as [aria-haspopup=false].

@engineering-this engineering-this mentioned this issue Jun 12, 2018
Merged
2 tasks
@mlewand mlewand mentioned this issue Jun 12, 2018
Closed
@Comandeer
Copy link
Member

Merged into next in c5c5e39.

@mlewand mlewand modified the milestones: Backlog, 4.11.0 Jul 3, 2018
@mlewand
Copy link
Contributor Author

mlewand commented Jul 3, 2018

Note that this change can already be previewed on our nightly preview demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility Issue related to accessibility. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Milestone
4.11.0
Development

No branches or pull requests
2 participants
@Comandeer @mlewand