Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CKEDITOR.tools.convertToPx returns last valid value, when called with wrong input #2223

Closed
engineering-this opened this issue Jul 13, 2018 · 1 comment
Closed

CKEDITOR.tools.convertToPx returns last valid value, when called with wrong input #2223

engineering-this opened this issue Jul 13, 2018 · 1 comment
Labels
resolution:wontfix The issue is valid, however, CKSource does not plan to fix it. type:bug A bug.

Comments

@engineering-this
Copy link
Contributor

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open console.
  2. Type 'CKEDITOR.tools.convertToPx( '10px' ) // returns 10.
  3. Type 'CKEDITOR.tools.convertToPx( 'poop' ) // returns 10.

Expected result

I'm not sure what it should return, maybe false, but definitely not last output.

Actual result

Same as above

Other details

  • Browser: …
  • OS: …
  • CKEditor version: …
  • Installed CKEditor plugins: …
@engineering-this engineering-this added type:bug A bug. status:confirmed An issue confirmed by the development team. labels Jul 13, 2018
@engineering-this engineering-this mentioned this issue Jul 13, 2018
Closed
@mlewand
Copy link
Contributor

mlewand commented Jul 21, 2018

This is actually not our issue, we're going to follow GIGO rule here.

@mlewand mlewand closed this as completed Jul 21, 2018
@mlewand mlewand added resolution:wontfix The issue is valid, however, CKSource does not plan to fix it. and removed status:confirmed An issue confirmed by the development team. labels Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolution:wontfix The issue is valid, however, CKSource does not plan to fix it. type:bug A bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mlewand @engineering-this