Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget definition insert method should include editor instance and command data #2253

Closed
mlewand opened this issue Jul 24, 2018 · 1 comment
Closed

Widget definition insert method should include editor instance and command data #2253

mlewand opened this issue Jul 24, 2018 · 1 comment
Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:widget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone
4.11.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Jul 24, 2018

Type of report

Feature request

Provide description of the new feature

As requested in the #235 PR, currently widgetDefinition.insert doesn't feature neither editor nor commandData passed to the command that caused the insert method call.

While editor issue could be mitigated, by storing editor variable as a local variable in the scope, and passing it later on, same can not happen for commandData.

Adding options object to the API that would provide editor and commandData will solve this problem.
@mlewand mlewand added type:feature A feature request. status:confirmed An issue confirmed by the development team. plugin:widget The plugin which probably causes the issue. target:major Any docs related issue that should be merged into a major branch. changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. labels Jul 24, 2018
This was referenced Jul 24, 2018
Merged
Merged
@mlewand mlewand added this to the 4.11.0 milestone Jul 25, 2018
@mlewand
Copy link
Contributor Author

mlewand commented Jul 25, 2018

Closed with #2255.

@mlewand mlewand closed this as completed Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:widget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Milestone
4.11.0
Development

No branches or pull requests
1 participant
@mlewand