Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize handler is visible in read-only mode #2816

Closed
Comandeer opened this issue Feb 16, 2019 · 1 comment
Closed

Resize handler is visible in read-only mode #2816

Comandeer opened this issue Feb 16, 2019 · 1 comment
Assignees
@Dumluregn
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:image2 The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.11.4

Comments

@Comandeer
Copy link
Member

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open https://ckeditor.com/docs/ckeditor4/latest/examples/image2.html
  2. Open browser console.
  3. Paste and execute following code in console: 
    CKEDITOR.instances.editor1.setReadOnly( true );
  4. Try to resize image in the first editor.

Expected result

  • Image can't be resized.
  • Resize handler is not visible.

Actual result

  • Image can be resized.
  • Resize handler is visible.

Other details

  • Installed CKEditor plugins: image2

There was #719, but it fixed issue only for editors loaded in read-only mode. As we're introducing hiding of drag handler in #865, it'd be nice to provide the same change also for resize handler.
@Comandeer Comandeer added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:image2 The plugin which probably causes the issue. labels Feb 16, 2019
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Feb 18, 2019
@mlewand mlewand added the good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. label Feb 25, 2019
@Dumluregn Dumluregn self-assigned this Feb 26, 2019
@Dumluregn Dumluregn mentioned this issue Feb 28, 2019
Merged
2 tasks
@f1ames f1ames added this to the 4.11.4 milestone Mar 22, 2019
@f1ames
Copy link
Contributor

f1ames commented Mar 26, 2019

Closed in 4b08ca6.

@f1ames f1ames closed this as completed Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dumluregn Dumluregn

Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:image2 The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.11.4
Development

No branches or pull requests
4 participants
@f1ames @Comandeer @mlewand @Dumluregn