Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto embed doesn't work with bottom toolbar #3000

Closed
nuljon opened this issue Mar 28, 2019 · 2 comments
Closed

Auto embed doesn't work with bottom toolbar #3000

nuljon opened this issue Mar 28, 2019 · 2 comments
Labels
plugin:autoembed The plugin which probably causes the issue. plugin:notification The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone
4.14.1

Comments

@nuljon
Copy link

nuljon commented Mar 28, 2019 •
edited by jacekbogdanski
Loading

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. install auto embed plugin using media embed tool (not semantic)
  2. config toolbar location bottom
  3. run editor in classic mode with firefox browser
  4. paste a url for a youtube video from the share link on youtube
  5. see ckeditor output 'trying to embed video url ...."
  6. f12 to see error in console of firefox debug:
    "type error f is null' (line is 670 position 86 in my custom build)

Expected result

placement of embedded video

Actual result

  1. see ckeditor output 'trying to embed video url ...."
  2. f12 to see error in console of firefox debug:
    "type error f is null' (line is 670 position 86 in my custom build)

Other details

  • CKEditor version: at least 4.10.0

FOR PROOF OF CAUSE IN THE MY TROUBLESHOOTING EFFORT I FIXED THIS SIMPLY BY EDITING LINE 670 TO READ
c.toolbar&&(f=c.ui.space("bottom")
INSTEAD OF
c.toolbar&&(f=c.ui.space("top")
@nuljon nuljon added the type:bug A bug. label Mar 28, 2019
@jacekbogdanski jacekbogdanski self-assigned this Apr 19, 2019
@jacekbogdanski
Copy link
Member

jacekbogdanski commented Apr 19, 2019 •
edited
Loading

Full error message:

image

Seems related to #624

@jacekbogdanski jacekbogdanski added plugin:autoembed The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. labels Apr 19, 2019
@jacekbogdanski jacekbogdanski removed their assignment Apr 19, 2019
@jacekbogdanski jacekbogdanski changed the title auto embed gives type error f is null when config toolbar location bottom Auto embed doesn't work with bottom toolbar Apr 19, 2019
@jacekbogdanski jacekbogdanski added the plugin:notification The plugin which probably causes the issue. label Apr 19, 2019
@jacekbogdanski jacekbogdanski mentioned this issue May 7, 2020
Merged
3 tasks
@f1ames
Copy link
Contributor

f1ames commented May 8, 2020

Fixed with c29775a.

@f1ames f1ames closed this as completed May 8, 2020
@f1ames f1ames added this to the 4.14.1 milestone May 8, 2020
This was referenced Aug 20, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugin:autoembed The plugin which probably causes the issue. plugin:notification The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
4.14.1
Development

No branches or pull requests
3 participants
@f1ames @jacekbogdanski @nuljon