range._getTableElement sometimes returns invalid result

[jacekbogdanski]

Type of report

Bug

Provide detailed reproduction steps (if any)

1. Open https://codepen.io/jacekbogdanski/pen/BeVmxX
2. Open console.

Expected

Table element for both console logs.

Actual

Null for both console logs.

---

The issue has been already covered for Safari, although it also occurs on Chrome. It probably makes sense to remove browser sniffing or at least enable the fix for Chrome. The issue is still reproducible on Safari when start container points outside the table.

https://github.com/ckeditor/ckeditor-dev/blob/36ad5d9fddff8173290854e36f25cfcea2b83cfb/core/dom/range.js#L2760-L2762

Also, the condition should be probably reversed for the endContainer i.e.

if ( endTable && start.equals( this.root ) ) {
	return end.getAscendant( tableElements, true );
}

The issue can be reproduced by making partial table selection without tableselection plugin. Mostly, you want to create selection where start or end container points into element outside the table - so selection should be placed on the edge of the table.

Other details

• Browser: Chrome, Safari
• CKEditor version: 4.7.0
• Installed CKEditor plugins: table