Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dialog positioning #3359

Closed
f1ames opened this issue Aug 27, 2019 · 0 comments · Fixed by #2413
Closed

Improve dialog positioning #3359

f1ames opened this issue Aug 27, 2019 · 0 comments · Fixed by #2413
Labels
plugin:dialog The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone
4.13.0

Comments

@f1ames
Copy link
Contributor

f1ames commented Aug 27, 2019

Type of report

Feature request

Provide description of the new feature

Extracted from #2413. See #2413 (comment).

The main improvements:

  • Dialog position margins (top, right, bottom, left) are kept on browser window resize (proportionally).
  • Resizing centered dialog keeps it positioned in a center (it is resized in all directions).
  • Performance improvements due to switching to native CSS positioning (CSS flex).
  • When dialog is opened, it is not possible to scroll it entirely out of viewport.
@f1ames f1ames added type:feature A feature request. plugin:dialog The plugin which probably causes the issue. target:major Any docs related issue that should be merged into a major branch. labels Aug 27, 2019
@f1ames f1ames added this to the 4.13.0 milestone Aug 27, 2019
@engineering-this engineering-this mentioned this issue Aug 27, 2019
Merged
2 tasks
@jacekbogdanski jacekbogdanski added the status:confirmed An issue confirmed by the development team. label Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugin:dialog The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Milestone
4.13.0
2 participants
@f1ames @jacekbogdanski