Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect getData event during dropping content into editable #3379

Closed
Comandeer opened this issue Sep 4, 2019 · 0 comments · Fixed by #3380
Closed

Incorrect getData event during dropping content into editable #3379

Comandeer opened this issue Sep 4, 2019 · 0 comments · Fixed by #3380
Assignees
@Comandeer
Labels
core The issue is caused by the editor core code. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone
4.13.0

Comments

@Comandeer
Copy link
Member

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open https://jsfiddle.net/Comandeer/jLcqf52e/
  2. Open console.
  3. Drag image and drop it in the "Drop here" place.

Expected result

Nothing is logged inside the console.

Actual result

beforeGetData event object is logged.

Other details

  • CKEditor version: 4.12.0+

The issue is caused by https://github.com/ckeditor/ckeditor-dev/pull/2776/files#diff-993e1987d3dfc48a16bdd6a1873521dbR1655 – this getData should be marked as internal and be invoked only if appropriate enter mode is active.
@Comandeer Comandeer added type:bug A bug. status:confirmed An issue confirmed by the development team. core The issue is caused by the editor core code. labels Sep 4, 2019
@Comandeer Comandeer added this to the 4.13.0 milestone Sep 4, 2019
@Comandeer Comandeer self-assigned this Sep 4, 2019
@Comandeer Comandeer mentioned this issue Sep 4, 2019
Merged
2 tasks
@jacekbogdanski jacekbogdanski added the regression This issue is a regression. label Feb 25, 2021
@jacekbogdanski jacekbogdanski mentioned this issue Feb 25, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Comandeer Comandeer

Labels
core The issue is caused by the editor core code. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
4.13.0
Development

Successfully merging a pull request may close this issue.

Fix for incorrect getData when content is inserted into the editor ckeditor/ckeditor4
2 participants
@Comandeer @jacekbogdanski