Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor throws an error during copy when selection starts in text an ends in widget #3498

Closed
msamsel opened this issue Sep 25, 2019 · 1 comment · Fixed by #3553
Closed

Editor throws an error during copy when selection starts in text an ends in widget #3498

msamsel opened this issue Sep 25, 2019 · 1 comment · Fixed by #3553
Assignees
@jacekbogdanski
Labels
plugin:widget The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone
Iteration 2020-2 ...

Comments

@msamsel
Copy link
Contributor

msamsel commented Sep 25, 2019

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open console
  2. Open test: /tests/plugins/widget/manual/block
  3. set content as paragraf and image:
<p>foo</p>

<figure class="image"><img alt="Lena Söderberg" src="/tests/_assets/lena.jpg" width="150" />
<figcaption>Image of <a href="http://en.
			wikipedia.org/wiki/Lena_S%C3%B6derberg">Lena Söderberg</a> used in<br />
many image processing experiments.</figcaption>
</figure>
  1. Make selection which starts in paragraph and ends on image (but before caption)
  2. Press CTRL/CMD+C

Expected result

no error in the console

Actual result

error in the console

Other details

Screenshot 2019-09-25 at 14 29 10

  • Browser: Chrome
  • OS: MacOS
  • CKEditor version: 4.13.0
  • Installed CKEditor plugins: …
@msamsel msamsel added type:bug A bug. status:confirmed An issue confirmed by the development team. regression This issue is a regression. plugin:widget The plugin which probably causes the issue. labels Sep 25, 2019
@f1ames f1ames added this to the Next milestone Sep 25, 2019
@f1ames f1ames added the target:minor Any docs related issue that can be merged into a master or major branch. label Sep 26, 2019
@msamsel msamsel self-assigned this Oct 3, 2019
@msamsel
Copy link
Contributor Author

msamsel commented Oct 8, 2019

Related to: #3551

@msamsel msamsel mentioned this issue Oct 8, 2019
Merged
2 tasks
@f1ames f1ames removed the target:minor Any docs related issue that can be merged into a master or major branch. label Nov 12, 2019
@f1ames f1ames modified the milestones: 4.13.1, Next, Iteration 2019-1 Dec 5, 2019
@msamsel msamsel assigned jacekbogdanski and unassigned msamsel Dec 18, 2019
@f1ames f1ames mentioned this issue Jan 9, 2020
Open
@jacekbogdanski jacekbogdanski mentioned this issue Jan 14, 2020
Closed
@Dumluregn Dumluregn mentioned this issue Feb 24, 2020
Open
This was referenced Aug 20, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacekbogdanski jacekbogdanski

Labels
plugin:widget The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
Iteration 2020-2 (4.14.0)
Development

Successfully merging a pull request may close this issue.

Prevent throwing error when partially selected widget is copied ckeditor/ckeditor4
3 participants
@f1ames @msamsel @jacekbogdanski