Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE Clipboard Access Prompt; On allow hits: Unable to get property 'plugins' of undefined or null reference #3931

Closed
ghost opened this issue Mar 16, 2020 · 2 comments
Assignees
Labels
core The issue is caused by the editor core code. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@ghost
Copy link

ghost commented Mar 16, 2020

Type of report

Bug

Provide detailed reproduction steps (if any)

Setup steps:

  1. use IE 11 (this is Internet Explorer specific issue)
  2. Ckeditor "samples" hosted in IIS; Put the ckeditor access site in Trusted sites.
  3. Make sure the default level for Clipboard access is Prompt
    Scripting > Allow Programmatic clipboard access -> Prompt

Steps to reproduce:

  1. Use Paste icon to trigger prompt call
  2. On IE prompt: "Do You want to allow this webpage to access your Clipboard"
  3. Press "Allow access"

Expected result

After prompt Allow action the clipboard is pasted

Actual result

The content is pasted. But it triggers also undefined exception in selection,js
: Unable to get property 'plugins' of undefined or null reference
line 1974 (v4.14.0 full source)
editor.plugins.tableselection
editor is undefined

Other details

  • Browser: Internet Explorer 11.1098.17763.0
  • OS: Windows 10 1809; IIS 10.0.17763.1
  • CKEditor version: 4.13.1; 4.14.0
  • Installed CKEditor plugins:
    Using this build configuration, with defines plugins
    build-config.txt

The error is reproducible on samples from the Build source
20200316 ErrorCondition Selection undefined editor

Thoughts on the condition
I see that on-line 2085 the editor is checked also for undefined condition.

So I wonder

  • if this place (line 1974) is amiss for undefined check
  • or it is some other context initialization error in case of broken clipboard access flow
@ghost ghost added the type:bug A bug. label Mar 16, 2020
@Comandeer Comandeer added core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. regression This issue is a regression. labels Mar 17, 2020
@Comandeer
Copy link
Member

Yes, it seems that it's a regression introduced in #3241. Adding simple check if editor is undefined should be enough.

@f1ames
Copy link
Contributor

f1ames commented Mar 30, 2020

Fixed in 7468d1c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core The issue is caused by the editor core code. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

3 participants