Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color button should handle ACF when custom colorButton_foreStyle config used #3996

Open
hub33k opened this issue Apr 20, 2020 · 1 comment
Open

Color button should handle ACF when custom colorButton_foreStyle config used #3996

hub33k opened this issue Apr 20, 2020 · 1 comment
Labels
plugin:colorbutton The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.

Comments

@hub33k
Copy link
Contributor

hub33k commented Apr 20, 2020 •
edited by f1ames
Loading

Type of report

Feature request

Provide description of the new feature

When we change color button settings to use classes instead of style attribute (via `colorButton_foreStyle` config), ACF removes class property when switching to source view and back. This can be easily solved by additional extraAllowedContent: 'span(*)' config. However, it will be more convenient if color button plugin could automatically detect such config and adjust ACF settings.

Example: https://codepen.io/f1ames/pen/JjYXZgp

Mght be related to #3994.
@hub33k hub33k added type:feature A feature request. plugin:colorbutton The plugin which probably causes the issue. workload:low labels Apr 20, 2020
@f1ames f1ames changed the title [Color button plugin] Make ACF more flexible for custom properties Color button should handle ACF when different colorButton_foreStyle config used Apr 20, 2020
@f1ames f1ames changed the title Color button should handle ACF when different colorButton_foreStyle config used Color button should handle ACF when custom colorButton_foreStyle config used Apr 20, 2020
@Dumluregn Dumluregn added the status:confirmed An issue confirmed by the development team. label Apr 27, 2020
@f1ames f1ames mentioned this issue May 5, 2020
Closed
@f1ames
Copy link
Contributor

f1ames commented May 5, 2020

See #3994 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugin:colorbutton The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@f1ames @hub33k @jacekbogdanski @Dumluregn