Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify filters namespace #4297

Closed
Comandeer opened this issue Sep 24, 2020 · 0 comments · Fixed by #4291
Closed

Unify filters namespace #4297

Comandeer opened this issue Sep 24, 2020 · 0 comments · Fixed by #4291
Assignees
@Comandeer
Labels
plugin:pastefromgdocs The plugin which probably causes the issue. plugin:pastefromlibreoffice The plugin which probably causes the issue. plugin:pastefromword The plugin which probably causes the issue. plugin:pastetools The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Milestone
4.16.0

Comments

@Comandeer
Copy link
Member

Type of report

Task

Provide description of the task

All filters are available via CKEDITOR.pasteFilters… except the common one, which is exposed only in CKEDITOR.plugins.pastetools.filters. Additionally image filter is not exposed in CKEDITOR.plugins.pastetools.filters.

We introduced CKEDITOR.pasteFilters as the simpler alias for CKEDITOR.plugins.pastetools.filters, however in the current implementation these two collections are totally separate. The easiest way to fix it is to make CKEDITOR.pasteFilters a real alias of `CKEDITOR.plugins.pastetools.filters.

Other details

  • Installed CKEditor plugins: pastetools, pastefromword, pastefromlibreoffice, pastefromgdocs
@Comandeer Comandeer added type:task Any other issue (refactoring, typo fix, etc). status:confirmed An issue confirmed by the development team. plugin:pastefromword The plugin which probably causes the issue. plugin:pastefromgdocs The plugin which probably causes the issue. plugin:pastetools The plugin which probably causes the issue. workload:low plugin:pastefromlibreoffice The plugin which probably causes the issue. labels Sep 24, 2020
@Comandeer Comandeer mentioned this issue Sep 28, 2020
Merged
3 tasks
@Comandeer Comandeer self-assigned this Sep 30, 2020
@f1ames f1ames added this to the 4.16.0 milestone Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Comandeer Comandeer

Labels
plugin:pastefromgdocs The plugin which probably causes the issue. plugin:pastefromlibreoffice The plugin which probably causes the issue. plugin:pastefromword The plugin which probably causes the issue. plugin:pastetools The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
4.16.0
Development

Successfully merging a pull request may close this issue.

Improve importing images from Microsoft Word ckeditor/ckeditor4
2 participants
@f1ames @Comandeer