Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support editor functions after reattach to DOM #4462

Closed
sculpt0r opened this issue Dec 31, 2020 · 2 comments · Fixed by #4601
Closed

Support editor functions after reattach to DOM #4462

sculpt0r opened this issue Dec 31, 2020 · 2 comments · Fixed by #4601
Assignees
@sculpt0r
Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone
4.17.0

Comments

@sculpt0r
Copy link
Contributor

Type of report

Feature request

Provide description of the new feature

Allow CKEditor works in a detached state.
We could support detaching and reattaching the editor (or its parent).

The main problem happens with the editable area based on iframe. Each time iframe is attached again - browser tries to reload it. Our iframe has an empty src attribute so it's impossible to just reload its content. We need to recreate it. It involves many bindings between references to documents and events.

Some integrations also may invoke the load event when data changes and editor is bonded to the data model.

Related to #4390
@sculpt0r sculpt0r added the type:feature A feature request. label Dec 31, 2020
@sculpt0r sculpt0r mentioned this issue Dec 31, 2020
Closed
@sculpt0r sculpt0r added core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. size:M labels Dec 31, 2020
@sculpt0r sculpt0r self-assigned this Jan 4, 2021
@sculpt0r
Copy link
Contributor Author

sculpt0r commented Jan 4, 2021

Related issue: ckeditor/ckeditor4-react#109

@sculpt0r sculpt0r mentioned this issue Jan 4, 2021
Closed
@f1ames f1ames mentioned this issue Jan 4, 2021
Merged
3 tasks
@Dumluregn Dumluregn mentioned this issue Jan 4, 2021
Closed
@sculpt0r sculpt0r mentioned this issue Jan 13, 2021
Closed
3 tasks
@f1ames f1ames mentioned this issue Feb 4, 2021
Open
@sculpt0r sculpt0r changed the title Support editor functions in detached mode Support editor functions after reattach to DOM Feb 17, 2021
@f1ames f1ames added size:S and removed size:M labels Feb 26, 2021
@f1ames f1ames added size:L and removed size:S labels Mar 29, 2021
@sculpt0r sculpt0r mentioned this issue Apr 1, 2021
Merged
3 tasks
@f1ames f1ames added size:M and removed size:L labels Apr 23, 2021
@sculpt0r sculpt0r mentioned this issue Apr 27, 2021
Open
@Dumluregn Dumluregn mentioned this issue May 13, 2021
Closed
@CKEditorBot
Copy link
Collaborator

Closed in #4601

@CKEditorBot CKEditorBot added this to the 4.17.0 milestone May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sculpt0r sculpt0r

Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
4.17.0
3 participants
@f1ames @sculpt0r @CKEditorBot