Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow attaching Balloon Panel to a range/selection #1176

Closed
mlewand opened this issue Nov 17, 2017 · 1 comment
Closed

Allow attaching Balloon Panel to a range/selection #1176

mlewand opened this issue Nov 17, 2017 · 1 comment
Assignees
@engineering-this
Labels
plugin:balloonpanel The plugin which probably causes the issue. plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone
4.11.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Nov 17, 2017 •
edited
Loading

Are you reporting a feature request or a bug?

Feature request

Provide detailed reproduction steps (if any)

It would be great if the Balloon Panel supported attaching to a range object, so that it could be placed literally anywhere in the text and so on.

In result balloonPanel.attach would support first parameter as a CKEDITOR.dom.range too.

Currently the limitation is that the balloon can only be attached to the whole element, so selection like that (in case of balloon toolbar) allows us only to position it relatively to the whole element:

image

Instead we'd like to attach it to the center of a selection.
@mlewand mlewand changed the title ## Are you reporting a feature request or a bug? Allow attaching Balloon Panel to a range Nov 17, 2017
@mlewand mlewand added status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request. labels Nov 17, 2017
@mlewand mlewand added the plugin:balloonpanel The plugin which probably causes the issue. label Dec 15, 2017
@mlewand mlewand added this to the Backlog milestone Dec 15, 2017
@mlewand mlewand changed the title Allow attaching Balloon Panel to a range Allow attaching Balloon Panel to a range/selection Dec 15, 2017
This was referenced Jan 25, 2018
Closed
Merged
@mlewand mlewand added the plugin:balloontoolbar The plugin which probably causes the issue. label May 21, 2018
@engineering-this engineering-this self-assigned this Aug 21, 2018
@Comandeer
Copy link
Member

Merged into major, will be released in CKEditor 4.11.0.

@Comandeer Comandeer modified the milestones: Backlog, 4.11.0 Aug 22, 2018
@mlewand mlewand added changelog:api A changelog entry should be put in the API section of the changelog. and removed changelog:api A changelog entry should be put in the API section of the changelog. labels Nov 5, 2018
@klonos klonos mentioned this issue Nov 7, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engineering-this engineering-this

Labels
plugin:balloonpanel The plugin which probably causes the issue. plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Milestone
4.11.0
Development

No branches or pull requests
3 participants
@Comandeer @mlewand @engineering-this