Merge pull request #40 from ckeditor/t/ckeditor5/1403

Fix: The UI buttons should be marked as toggleable for better assistive technologies support (see ckeditor/ckeditor5#1403).
ckeditor · Aug 12, 2019 · aa24686 · aa24686
2 parents c48b703 + fa34b49
commit aa24686
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/blockquoteui.js b/src/blockquoteui.js
@@ -35,7 +35,8 @@ export default class BlockQuoteUI extends Plugin {
 			buttonView.set( {
 				label: t( 'Block quote' ),
 				icon: quoteIcon,
-				tooltip: true
+				tooltip: true,
+				isToggleable: true
 			} );
 
 			// Bind button model to command.

diff --git a/tests/blockquoteui.js b/tests/blockquoteui.js
@@ -40,6 +40,7 @@ describe( 'BlockQuoteUI', () => {
 			expect( button ).to.have.property( 'label', 'Block quote' );
 			expect( button ).to.have.property( 'icon' );
 			expect( button ).to.have.property( 'tooltip', true );
+			expect( button ).to.have.property( 'isToggleable', true );
 		} );
 
 		it( 'has isOn bound to command\'s value', () => {