-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
view.Writer is missing in inputTransformation event #2674
Comments
Seems like new writer https://github.com/ckeditor/ckeditor5-engine/issues/1501 could be suitable for this. |
@Reinmar I'd like to raise this issue. As we have this in the docs: https://github.com/ckeditor/ckeditor5-clipboard/blob/74c3c43085cb414696eafeddc31e354eeb3f0f1a/docs/framework/guides/deep-dive/clipboard.md#L70-L77 Which implies to import something from the engine aaaaand we tend to avoid it :) (#667, https://github.com/ckeditor/ckeditor5-engine/issues/1555, https://github.com/ckeditor/ckeditor5-engine/issues/1556). I was to propose something similar as @scofalik proposed. Adding even a ps.: I've stumbled upon this while doing PR review. |
There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue. |
We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it). |
At the moment the document fragment available in
inputTransformation
event callbacks is useless, because there's no convenient way to modify it. We are modifying model/view trees through model/view writers, unfortunately,view.Writer
instance is not available insideinputTransformation
callbacks.My proposition is to make it available as another parameter (next to
data
) or as a parameter insidedata
object. We could useview.View#_writer
but it is private. Or we can create a newview.Writer
instance for clipboard pipeline.The text was updated successfully, but these errors were encountered: