-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move PluginCollection and Plugin to utils #2877
Comments
Also, I think it would be a good change in general. A class should do one task. This class has a task to solve dependencies and it is what it really do. Making it a util lets developers understand it easier. |
Makes sense. Then Related ticket: https://github.com/ckeditor/ckeditor5-core/issues/54. |
But I don't like this for CKEditor: _.extend( this, contex ); We should keep the constructor( editor ) {
this.editor = editor;
} |
This should be handled together with https://github.com/ckeditor/ckeditor5-core/issues/78. |
BTW, soon we'll make commands and command collection utils too and ckeditor5-core will become a set of utils and interfaces (cause editor will be an interface too). |
Closing due to lack of interest in this now. |
What
Plugin
/PluginCollection
are, is the util to solve problems with the dependencies tree. It's enough to renameeditor
variable tocontext
and change docs to make it more flexible util. It's very helpful to split a project into pieces, event if it is editor-independent.Note that it's possible to make it compatible with the editors plugins:
The text was updated successfully, but these errors were encountered: