Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations are missing on the fresh cloned and built repo ckeditor5-build-classic #7044

Closed
ma2ciek opened this issue Nov 9, 2017 · 1 comment
Closed

Translations are missing on the fresh cloned and built repo ckeditor5-build-classic #7044

ma2ciek opened this issue Nov 9, 2017 · 1 comment
Assignees
@ma2ciek
Labels
package:dev type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 13

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Nov 9, 2017

Steps to reproduce:

git clone https://github.com/ckeditor/ckeditor5-build-classic
npm i
npm run build

Error:

screen shot 2017-11-09 at 11 01 52
...
@ma2ciek ma2ciek self-assigned this Nov 9, 2017
@ma2ciek
Copy link
Contributor Author

ma2ciek commented Nov 9, 2017

So the issue is because of the RegExps used by translation service for resolving paths to PO files, that are looking for ckeditor5-* packages and are finding ckeditor5-build-classic instead of correct packages in node_modules. It should be easy to fix.

pomek referenced this issue in ckeditor/ckeditor5-dev Nov 9, 2017
@pomek
Merge pull request #303 from ckeditor/t/302
78e1d5a 
Fix: Made webpack plugin being able to run inside the ckeditor5-* package. Closes #302.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-dev May 18, 2020
@mlewand mlewand added this to the iteration 13 milestone May 18, 2020
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:dev labels May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma2ciek ma2ciek

Labels
package:dev type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 13
Development

No branches or pull requests
2 participants
@ma2ciek @mlewand