Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink "release main package" task #6913

Closed
Reinmar opened this issue Feb 22, 2017 · 2 comments
Closed

Rethink "release main package" task #6913

Reinmar opened this issue Feb 22, 2017 · 2 comments
Labels
package:dev resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 22, 2017

In #6898 we worked on releasing dependencies. Now we also need to think how the task to release the main package should work. What are the rules for bumping up the main package's version?

I think that the semantics we want to implement is that if any of the sub packages had a major release, the main package should have it too. If minor, then minor and if only patch versions were released, then the main package should be bumped by a patch too.

@Reinmar
Copy link
Member Author

Reinmar commented Feb 23, 2017

OK, I talked with @fredck about this and we want ckeditor5's version to reflect all changes in the framework. So, if there was any major change, the framework also gets a major release. Etc.

Also, so I don't forget this – ckeditor5's changelog should contain entries generated for the ckeditor5 package itself and a list of updated dependencies with prev+new versions and links to these releases.

@pomek
Copy link
Member

pomek commented Oct 9, 2018

I'm closing it as a DUP of https://github.com/ckeditor/ckeditor5-dev/issues/427. In that issue, we mentioned a new solution that was introduced with related PR.

@pomek pomek closed this as completed Oct 9, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-dev May 18, 2020
@mlewand mlewand added this to the iteration 20 milestone May 18, 2020
@mlewand mlewand added resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:dev labels May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:dev resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

3 participants