Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UploadGateway should not be created when cloudServices#token in not provided #2559

Closed
ma2ciek opened this issue Nov 2, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-easy-image#10
Closed

UploadGateway should not be created when cloudServices#token in not provided #2559

ma2ciek opened this issue Nov 2, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-easy-image#10
Assignees
@ma2ciek
Labels
package:easy-image type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 13

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Nov 2, 2017

I changed the behavior in ckeditor/ckeditor5-easy-image#8 and move the check to the new cloud services package. But it turned out, that the CloudServices shouldn't throw an error when the tokenUrl config is not provided. So, in this case, all instances depending on the token shouldn't be created.
@ma2ciek ma2ciek self-assigned this Nov 2, 2017
@pomek
Copy link
Member

pomek commented Nov 2, 2017

Would be good to see why this change is required. In other words – ticket should contain a description which explains it.

@ma2ciek
Copy link
Contributor Author

ma2ciek commented Nov 2, 2017 •
edited
Loading

Would be good to see why this change is required. In other words – ticket should contain a description which explains it.

Thanks and sorry for the hurry. I added a description.

pjasiun referenced this issue in ckeditor/ckeditor5-easy-image Nov 2, 2017
Merge pull request #10 from ckeditor/t/9
cdc6662 
Fix: Prevented UploadGateway from being created when cloudServices#tokenUrl is not provided. Closes #9.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-easy-image Oct 9, 2019
@mlewand mlewand added this to the iteration 13 milestone Oct 9, 2019
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:easy-image labels Oct 9, 2019
@ma2ciek ma2ciek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma2ciek ma2ciek

Labels
package:easy-image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 13
3 participants
@pomek @ma2ciek @mlewand