Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for keyup event on document #4119

Closed
pomek opened this issue Jul 19, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-engine#1027
Closed

Support for keyup event on document #4119

pomek opened this issue Jul 19, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-engine#1027
Assignees
Labels
package:engine type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone

Comments

@pomek
Copy link
Member

pomek commented Jul 19, 2017

In order to detect whether the user keeps the Backspace key, we need to add support for the keyup event called on Document.

It's required in order to implement a test case II from here – https://github.com/ckeditor/ckeditor5-typing/issues/61#issuecomment-314705304.

@pomek pomek self-assigned this Jul 19, 2017
@Reinmar
Copy link
Member

Reinmar commented Jul 19, 2017

We agreed on a different solution – that the keydown could have a "sequence" property with the number identifying thre 1st, 2nd, etc. press (without release).

@Reinmar
Copy link
Member

Reinmar commented Jul 19, 2017

OTOH, exposing keyup may be more flexible. But you'll need much more code in ckeditor/ckeditor5-typing#61 to handle that.

OTTH... we'd actually need to count which exactly key does this sequence apply to. So perhaps that generic sequence in keydown isn't a good idea. E.g. ctrl+backspace is already two keydowns but you'd expect that sequence is 1 ;/

Let's better add the keyup then and have the code inside the typing feature.

@Reinmar
Copy link
Member

Reinmar commented Jul 19, 2017

There's also the third option – to have keyup fired by the KeyObserver and the sequence handled by the DeleteObserver. Let's do this.

Reinmar referenced this issue in ckeditor/ckeditor5-engine Jul 19, 2017
Feature: Introduced `view.Document#keyup` event (fired by the `KeyObserver`). Closes #1026.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:engine labels Oct 9, 2019
zadam added a commit to zadam/trilium-ckeditor5 that referenced this issue Jan 21, 2024
zadam added a commit to zadam/trilium-ckeditor5 that referenced this issue Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants