Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port methods which fire events to ObservableMixin.decorate() #4077

Closed
Reinmar opened this issue Jun 7, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#966
Closed

Port methods which fire events to ObservableMixin.decorate() #4077

Reinmar opened this issue Jun 7, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#966
Assignees
@Reinmar
Labels
package:engine type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 11

Comments

@Reinmar
Copy link
Member

Reinmar commented Jun 7, 2017

Requires https://github.com/ckeditor/ckeditor5-utils/issues/162.

We introduce this new function which will simplify this common pattern.
@Reinmar Reinmar self-assigned this Jun 7, 2017
@Reinmar Reinmar changed the title Port methods firing events to ObservableMixin.decorate() Port methods which fire events to ObservableMixin.decorate() Jun 7, 2017
szymonkups referenced this issue in ckeditor/ckeditor5-engine Jun 13, 2017
@szymonkups
Merge pull request #966 from ckeditor/t/963
9176877 
Internal: Used `ObservableMixin.decorate()` for methods which already fire events. Closes #963.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:engine labels Oct 9, 2019
@Reinmar Reinmar mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Reinmar Reinmar

Labels
package:engine type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

Used ObservableMixin.decorate() for methods which already fire events ckeditor/ckeditor5-engine
2 participants
@Reinmar @mlewand