Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Merge pull request #270 from ckeditor/t/ckeditor5/1341
Browse files Browse the repository at this point in the history
Fix: There should be no memory leaks when the editor is created and destroyed (see ckeditor/ckeditor5#1341).
  • Loading branch information
oleq authored Jan 22, 2019
2 parents a1b03b9 + 0731273 commit 205f119
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions src/imagetextalternative/imagetextalternativeui.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@ export default class ImageTextAlternativeUI extends Plugin {
this._createForm();
}

/**
* @inheritDoc
*/
destroy() {
super.destroy();

// Destroy created UI components as they are not automatically destroyed (see ckeditor5#1341).
this._form.destroy();
}

/**
* Creates a button showing the balloon panel for changing the image text alternative and
* registers it in the editor {@link module:ui/componentfactory~ComponentFactory ComponentFactory}.
Expand Down

0 comments on commit 205f119

Please sign in to comment.