-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image should re-render view on load #5118
Comments
It looks more like a bug in ckeditor5-link. Since there's no selection enclosing the image after the external insertion, the link balloon should simply hide and no image UI should show up. The sample does not show what happened to the selection after the insertion, though. If it's still in the link, the link balloon should simply be re-positioned. |
Link is still in the document and selection is in the link element. |
Gif has been replaced. |
We need to get image from DOM, listen to its |
cc @szymonkups |
I added MT for this ticket |
Fix: The UI should update once the image is loaded. Closes #142. Used the `EditorUI#update` event instead of `View#render` to attach the UI components (see ckeditor/ckeditor5-core#130).
am getting this empty Tags |
[edited]
Sometimes the source of the image element is loaded async and this causes layout change. We need to reposition UI attached to the content then.
E.g. Image element is rendered in the DOM after pressing
Start external changes
but image is heavy and we need to wait a couple of seconds to see the source of the image. The image is loaded but UI is in the old position because its its update was not triggered:The text was updated successfully, but these errors were encountered: