Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename uploadImage to imageUpload (command and button) #5136

Closed
Reinmar opened this issue Mar 12, 2018 · 0 comments
Closed

Rename uploadImage to imageUpload (command and button) #5136

Reinmar opened this issue Mar 12, 2018 · 0 comments
Assignees
@Reinmar
Labels
package:image type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 14

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 12, 2018

When renaming components and commands recently we decided to keep the name uploadImage so it's consistent with insertTable or removeHighlight.

However, this made uploadImage inconsistent with:

  • The plugin name (ImageUpload)
  • Other names in this package: imageStyle command, imageStyle:* buttons, etc.

So, let's make it more consistent locally.
@Reinmar Reinmar self-assigned this Mar 12, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:image labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Reinmar Reinmar

Labels
package:image type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 14
Development

No branches or pull requests
2 participants
@Reinmar @mlewand