Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextAlternativeFormView button needs update #5137

Closed
dkonopka opened this issue Mar 15, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-image#188
Closed

TextAlternativeFormView button needs update #5137

dkonopka opened this issue Mar 15, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-image#188
Assignees
@oleq
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 15

Comments

@dkonopka
Copy link
Contributor

After #810 we have forgotten about button update in Alternative Text Form.

cc @oleq

screen shot 2018-03-15 at 13 40 16

screen shot 2018-03-15 at 13 41 25
@oleq oleq self-assigned this Mar 15, 2018
dkonopka referenced this issue in ckeditor/ckeditor5-link Mar 15, 2018
@dkonopka
Merge pull request #185 from ckeditor/t/ckeditor5-image/187
a5eebdb 
Other: Used .ck-button_save and _cancel CSS classes to make the link form view buttons colorful (see ckeditor/ckeditor5-image#187).
dkonopka referenced this issue in ckeditor/ckeditor5-theme-lark Mar 15, 2018
@dkonopka
Merge pull request #162 from ckeditor/t/ckeditor5-image/187
531aec2 
Feature: Implemented .ck-button_save and _cancel classes with distinctive colors (see ckeditor/ckeditor5-image#187).
dkonopka referenced this issue in ckeditor/ckeditor5-image Mar 15, 2018
@dkonopka
Merge pull request #188 from ckeditor/t/187
25c17ad 
Other: Made the image text alternative form buttons thicker with a fill color and no background. Closes #187.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 15 milestone Oct 9, 2019
@mlewand mlewand added domain:ui/ux This issue reports a problem related to UI or UX. type:bug This issue reports a buggy (incorrect) behavior. package:image labels Oct 9, 2019
This was referenced Oct 11, 2019
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 15
3 participants
@oleq @mlewand @dkonopka