Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image upload placeholder might be not visible on other clients #5140

Closed
szymonkups opened this issue Mar 20, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-image#192
Closed

Image upload placeholder might be not visible on other clients #5140

szymonkups opened this issue Mar 20, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-image#192
Assignees
@szymonkups
Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 15

Comments

@szymonkups
Copy link
Contributor

ImageUploadProgress plugin is using uploadStatus attribute to show placeholder image, progress bar etc.
Problem is that it assumes that all attribute values will be in order:

  • reading -> show placeholder
  • uploading -> show progress bar
  • complete -> hide

This might not be true in terms of external changes. Attribute change to reading and uploading might come together as an external change and differ changes will only return the latter value.
@szymonkups szymonkups self-assigned this Mar 20, 2018
oskarwrobel referenced this issue in ckeditor/ckeditor5-image Mar 21, 2018
@oskarwrobel
Merge pull request #192 from ckeditor/t/191
66d67c0 
Fix: Fixed image upload progress updates. Now each upload status is treated separately. Closes #191.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 15 milestone Oct 9, 2019
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:image labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonkups szymonkups

Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 15
Development

Successfully merging a pull request may close this issue.

Fixed image upload progress updates ckeditor/ckeditor5-image
2 participants
@szymonkups @mlewand