Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageUploadProgress: image element should be "cleaned" when it loses uploadId #5145

Closed
scofalik opened this issue Apr 4, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-image#201
Closed

ImageUploadProgress: image element should be "cleaned" when it loses uploadId #5145

scofalik opened this issue Apr 4, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-image#201
Assignees
@scofalik
Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 15

Comments

@scofalik
Copy link
Contributor

scofalik commented Apr 4, 2018

At this moment, if in the same batch, uploadId is changed to null, the uploadStatus change is not converted, because uploadId is already null and the converter returns quickly.

https://github.com/ckeditor/ckeditor5-image/blob/master/src/imageupload/imageuploadprogress.js#L61-L65

Instead, I think that if uploadId is null, then image should be cleared out of anything connected with progress. Then, it will work correctly if multiple deltas will come together from collaboration.
@scofalik scofalik self-assigned this Apr 4, 2018
pjasiun referenced this issue in ckeditor/ckeditor5-image Apr 4, 2018
Merge pull request #201 from ckeditor/t/200
5fadcf0 
Fix: Image element will be cleared from upload progress classes if `uploadId` attribute changed to `null`. Closes #200.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 15 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:image labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 15
Development

Successfully merging a pull request may close this issue.

Image element should be cleared from progress if uploadId changed to null ckeditor/ckeditor5-image
2 participants
@scofalik @mlewand