Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible superfluous requires in ImageStyleEditing #5176

Closed
jodator opened this issue Dec 11, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-image#266
Closed

Possible superfluous requires in ImageStyleEditing #5176

jodator opened this issue Dec 11, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-image#266
Assignees
@jodator
Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 22

Comments

@jodator
Copy link
Contributor

jodator commented Dec 11, 2018

The ImageStyleEditing requires ImageStyle - I think that is against our rules of plugins loading as one should explicitly enable both AFAIK:

CKEditor.create( {
    plugins: [ 'Image', 'ImageStyle', ... ] 
} )

https://github.com/ckeditor/ckeditor5-image/blob/c8a52395f183cd6cff6a6ac3ccf182a8973a7bfd/src/imagestyle/imagestyleediting.js#L27
@oleq
Copy link
Member

oleq commented Dec 20, 2018

Image requires ImageEditing. So yes, requiring it again in the ImageStyleEditing makes no sense IMO. It's unlikely anyone would want to use ImageStyle without... Image.

ImageCaptionEditing has no such require anyway.

f1ames referenced this issue in ckeditor/ckeditor5-image Jan 3, 2019
@f1ames
Merge pull request #266 from ckeditor/t/261
5dea054 
Other: Remove `ImageEditing` plugin from requires method of `ImageStyleEditing`. Closes #261.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 22 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:image labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 22
Development

Successfully merging a pull request may close this issue.

Remove ImageEditing from requires method of ImageStyleEditing. ckeditor/ckeditor5-image
3 participants
@jodator @oleq @mlewand