Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract widget API to a separate package #5053

Closed
Reinmar opened this issue Jan 24, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-image#88
Closed

Extract widget API to a separate package #5053

Reinmar opened this issue Jan 24, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-image#88
Labels
package:image type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 9

Comments

@Reinmar
Copy link
Member

Reinmar commented Jan 24, 2017

Things to remember:

  • you shouldn't need to define generic converters like src/converters~modelToViewSelection for each widget, so this should be exposed as some kind of util.
@Reinmar
Copy link
Member Author

Reinmar commented Feb 21, 2017

Requires: https://github.com/ckeditor/ckeditor5-image/issues/57

@szymonkups szymonkups self-assigned this Mar 31, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-image Mar 31, 2017
@Reinmar
Merge pull request #88 from ckeditor/t/35
016b68e 
Other: Extracted widget API to a separate package. Closes #35.

BREAKING CHANGE: The widget API is now available in the `ckeditor5-widget` package. See #35.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added type:task This issue reports a chore (non-production change) and other types of "todos". package:image labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
@oleq oleq mentioned this issue Apr 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:image type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 9
Development

Successfully merging a pull request may close this issue.

T/35 Extracted widget API to separate package ckeditor/ckeditor5-image
3 participants
@Reinmar @szymonkups @mlewand