Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema: caption should inherit from $block #5089

Closed
scofalik opened this issue Apr 10, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-image#95
Closed

Schema: caption should inherit from $block #5089

scofalik opened this issue Apr 10, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-image#95
Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 10

Comments

@scofalik
Copy link
Contributor

Because of Schema imperfection described here: https://github.com/ckeditor/ckeditor5-engine/issues/532#issuecomment-292892032 and changes proposed here ckeditor/ckeditor5-link#98 and here ckeditor/ckeditor5-basic-styles#41 we need to take care of caption element which should inherit $block now to be able to have bold/italic text.
Reinmar referenced this issue in ckeditor/ckeditor5-image Apr 11, 2017
@Reinmar
Merge pull request #95 from ckeditor/t/94
02869eb 
Fix: The `caption` item should inherit from `$block` to automatically allow the same content. Closes #94.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 10 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:image labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 10
Development

Successfully merging a pull request may close this issue.

Changed: caption in schema now inherits from $block. ckeditor/ckeditor5-image
2 participants
@scofalik @mlewand