Merge pull request #201 from ckeditor/t/173

Other: The link button will be active when the selection is placed inside a link. Closes #173.
ckeditor · Sep 7, 2018 · c9e4bc3 · c9e4bc3
2 parents a42ba3c + 44e0eac
commit c9e4bc3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/linkui.js b/src/linkui.js
@@ -186,7 +186,7 @@ export default class LinkUI extends Plugin {
 			button.tooltip = true;
 
 			// Bind button to the command.
-			button.bind( 'isEnabled' ).to( linkCommand, 'isEnabled' );
+			button.bind( 'isOn', 'isEnabled' ).to( linkCommand, 'value', 'isEnabled' );
 
 			// Show the panel on button click.
 			this.listenTo( button, 'execute', () => this._showUI() );

diff --git a/tests/linkui.js b/tests/linkui.js
@@ -84,9 +84,15 @@ describe( 'LinkUI', () => {
 				const command = editor.commands.get( 'link' );
 
 				command.isEnabled = true;
+				command.value = true;
+
+				expect( linkButton.isOn ).to.be.true;
 				expect( linkButton.isEnabled ).to.be.true;
 
 				command.isEnabled = false;
+				command.value = false;
+
+				expect( linkButton.isOn ).to.be.false;
 				expect( linkButton.isEnabled ).to.be.false;
 			} );