Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the balloon pop up when part of a link is selected? #4804

Closed
Reinmar opened this issue Jul 21, 2017 · 4 comments
Closed

Should the balloon pop up when part of a link is selected? #4804

Reinmar opened this issue Jul 21, 2017 · 4 comments
Labels
package:link resolution:expired This issue was closed due to lack of feedback. status:discussion status:stale type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Reinmar
Copy link
Member

Reinmar commented Jul 21, 2017

It came out during testing the unlink option: ckeditor/ckeditor5-link#142 (comment).

jul-21-2017 09-11-54

Since we're planning to remove the unlink button from the toolbar I think that the balloon should show up in more cases because it's not that intuitive that you need to press Ctrl+K or the link button to unlink part of a text.

@oleq
Copy link
Member

oleq commented Jul 21, 2017

What would happen if one changed the URL and saved it in such situation? Split the link? Update the entire link? This change could affect the UX of the linking in general.

@Reinmar
Copy link
Member Author

Reinmar commented Jul 21, 2017

Yeah. This part is tricky. You may really want to achieve both results – changing just a part of it or the whole link.

However, I'd say that the actions you'd want to do for partial selections are (in frequency order):

  • unlink (!!!!!!!)
  • change the whole link
  • change the selected part of the link

Which seriously worries me since we decided to remove the unlink button from the toolbar. We need the partial unlinking functionality somewhere. We also need the "open link" feature, so maaaybe, we should think how to provide both in some simplified balloon? IDK.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added status:discussion type:improvement This issue reports a possible enhancement of an existing feature. package:link labels Oct 9, 2019
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 2, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:link resolution:expired This issue was closed due to lack of feedback. status:discussion status:stale type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

5 participants