Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link balloon is too narrow #4805

Closed
Reinmar opened this issue Aug 15, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-link#151
Closed

Link balloon is too narrow #4805

Reinmar opened this issue Aug 15, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-link#151
Assignees
@oleq
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 12

Comments

@Reinmar
Copy link
Member

Reinmar commented Aug 15, 2017

It should at least consider such languages:

image

I can see that in https://github.com/ckeditor/ckeditor5-link/issues/31#issuecomment-316992952 we didn't plan to change the layout of this balloon but since it will be less often opened perhaps it could become slightly bigger.

This would also address issues with a very narrow link URL input.
@oleq
Copy link
Member

oleq commented Aug 16, 2017

Two things should be done here:

  1. The URL input should scale to 100% width.
  2. There should be a right margin after the "Unlink" button to clearly separate two things (saving/closing and unlinking).

@Reinmar
Copy link
Member Author

Reinmar commented Aug 16, 2017

👍 for 1 and 2.

@oleq oleq self-assigned this Aug 16, 2017
oskarwrobel referenced this issue in ckeditor/ckeditor5-link Sep 8, 2017
@oskarwrobel
Merge pull request #151 from ckeditor/t/145
05b3bf4 
Fix: The URL input should span the width of the balloon. Closes #145.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 12 milestone Oct 9, 2019
@mlewand mlewand added domain:ui/ux This issue reports a problem related to UI or UX. status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:link labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 12
Development

Successfully merging a pull request may close this issue.

t/145: The URL input should span the width of the balloon ckeditor/ckeditor5-link
3 participants
@Reinmar @oleq @mlewand