Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging down double-row header cell results in broken table #3212

Closed
f1ames opened this issue Jul 12, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-table#91
Closed

Merging down double-row header cell results in broken table #3212

f1ames opened this issue Jul 12, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-table#91
Assignees
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@f1ames
Copy link
Contributor

f1ames commented Jul 12, 2018

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

v10.1.0

📋 Steps to reproduce

  1. Go to https://docs.ckeditor.com/ckeditor5/latest/features/table.html.
  2. Place selection in the top-left cell.
  3. Open merging/splitting panel and apply Merge cell down.

table1

✅ Expected result

Cell is correctly merged.

❎ Actual result

Cell is not merged and the cell below disappears.

📃 Other details that might be useful

Tested on Chrome 67.0.3396.99 .

Looks like this is the issue with thead, works fine if there is only tbody. Also if thead is a single row, Merge cell down option is disabled.

@jodator
Copy link
Contributor

jodator commented Jul 12, 2018

Cell is correctly merged.

The expected result is that the merge shouldn't be possible - the mege would cross <thead> & <tbody> boundary which isn't allowed - now this happens:

<th rowspan="3"></th>

So this table cell is "properly" expanded (from rowspan="2"), the cell is merged with one below but the browser (correctly) doesn't render this and we have a collision.

Probably an easy/small fix though.

ps.: The merge up is properly grayed-out.

@jodator jodator self-assigned this Jul 12, 2018
scofalik referenced this issue in ckeditor/ckeditor5-table Jul 27, 2018
Fix: Merging down rowspanned cell from the head with a cell in body is now disabled. Closes #86.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the iteration 20 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:table labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants