Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BalloonPanelView's limiter option should be configurable #5322

Closed
oleq opened this issue Mar 22, 2017 · 6 comments
Closed

BalloonPanelView's limiter option should be configurable #5322

oleq opened this issue Mar 22, 2017 · 6 comments
Labels
package:ui type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone

Comments

@oleq
Copy link
Member

oleq commented Mar 22, 2017

ATM the limiter is hard coded by the Link Plugin to the editable element the selection is anchored to. Depending on the integration, some editors may be restricted by parents with overflow:scroll and then such limiter makes little sense as getOptimalPosition() works on DOMRects, which are the same regardless of the element being cropped by the parent.

Proposed config names: ui.floatingElementsLimiter, ui.balloonPanel.limiter.

Additionally getOptimalPosition() could check all the ancestors of the limiter which have overflow different than visible and intersect all their rects one by one up to window to find the real visible area which is available to position the BalloonPanel. That would, in most cases, make the limiter configuration obsolete.

@oleq
Copy link
Member Author

oleq commented Mar 22, 2017

Asking @oskarwrobel to chime in. I wonder if the getOptimalPosition() fix is just enough.

@oskarwrobel
Copy link
Contributor

I wonder if the getOptimalPosition() fix is just enough.

I think it should be enough. Worth to try.

@Reinmar
Copy link
Member

Reinmar commented Mar 22, 2017

ui.floatingElementsLimiter still indicates that it's only about floating stuff (what about "aside" stuff?). And perhaps instead of "elements" you could say "components"?

@Reinmar
Copy link
Member

Reinmar commented Mar 22, 2017

Finally, "limiter" is how you call these things in the code. Please keep in mind that the config is for the "outside" world. I don't mean that "limiter" must be wrong, but perhaps there's a convention used by some other libraries.

@oleq
Copy link
Member Author

oleq commented Mar 23, 2017

We'll try to fix up the getOptimalPosition() a little first. There's a chance it will make the configuration obsolete. Plus, it will get even smarter, which is great for other possible use cases.

@oleq
Copy link
Member Author

oleq commented Apr 19, 2017

Closed by ckeditor/ckeditor5-utils#149.

@oleq oleq closed this as completed Apr 19, 2017
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 10 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:ui labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ui type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

4 participants