Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createListDropdown helper should use clickOutsideHandler #5410

Closed
oleq opened this issue Sep 28, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-ui#353
Closed

createListDropdown helper should use clickOutsideHandler #5410

oleq opened this issue Sep 28, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-ui#353
Assignees
@oleq
Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 14

Comments

@oleq
Copy link
Member

oleq commented Sep 28, 2017

ATM createListDropdown uses own custom click handling. It's redundant.
@oleq
Copy link
Member Author

oleq commented Sep 29, 2017

It turned out in the PR that the issue must wait for #5384.

@oleq oleq self-assigned this Dec 12, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-ui Jan 16, 2018
@Reinmar
Merge pull request #353 from ckeditor/t/311a
269e97b 
Other: The `closeDropdownOnBlur()` helper should use `clickOutsideHandler()`. Decorated the `View#render()` method. Closes #311.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:ui labels Oct 9, 2019
This was referenced Oct 11, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 14
2 participants
@oleq @mlewand