Merge pull request #44 from ckeditor/t/43

Fix: Bound ImageUploadButton#isEnabled to ImageUploadCommand#isEnabled. Closes #43.
ckeditor · Jul 12, 2017 · ba6de66 · ba6de66
2 parents aff6382 + f0aa610
commit ba6de66
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/imageuploadbutton.js b/src/imageuploadbutton.js
@@ -36,6 +36,7 @@ export default class ImageUploadButton extends Plugin {
 		// Setup `insertImage` button.
 		editor.ui.componentFactory.add( 'insertImage', locale => {
 			const view = new FileDialogButtonView( locale );
+			const command = editor.commands.get( 'imageUpload' );
 
 			view.set( {
 				label: t( 'Insert image' ),
@@ -45,6 +46,8 @@ export default class ImageUploadButton extends Plugin {
 				allowMultipleFiles: true
 			} );
 
+			view.bind( 'isEnabled' ).to( command );
+
 			view.on( 'done', ( evt, files ) => {
 				for ( const file of files ) {
 					editor.execute( 'imageUpload', { file } );

diff --git a/tests/imageuploadbutton.js b/tests/imageuploadbutton.js
@@ -37,6 +37,19 @@ describe( 'ImageUploadButton', () => {
 		expect( button ).to.be.instanceOf( FileDialogButtonView );
 	} );
 
+	it( 'should be disabled while ImageUploadCommand is disabled', () => {
+		const button = editor.ui.componentFactory.create( 'insertImage' );
+		const command = editor.commands.get( 'imageUpload' );
+
+		command.isEnabled = true;
+
+		expect( button.isEnabled ).to.true;
+
+		command.isEnabled = false;
+
+		expect( button.isEnabled ).to.false;
+	} );
+
 	it( 'should execute imageUpload command', () => {
 		const executeStub = sinon.stub( editor, 'execute' );
 		const button = editor.ui.componentFactory.create( 'insertImage' );