Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image placeholder should look better on wider editor #2827

Closed
szymonkups opened this issue Oct 2, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-upload#64
Closed

Image placeholder should look better on wider editor #2827

szymonkups opened this issue Oct 2, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-upload#64
Assignees
@szymonkups
Labels
package:upload type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 12

Comments

@szymonkups
Copy link
Contributor

When editor is wide, placeholder it doesn't look good:
image

When placeholder is visible, image should occupy whole available width. We should also create placeholder that have different width/height ratio to not take as much vertical space when it will be on 100% of the width.
@szymonkups szymonkups self-assigned this Oct 2, 2017
pjasiun referenced this issue in ckeditor/ckeditor5-upload Oct 2, 2017
Merge pull request #64 from ckeditor/t/63
edb5e81 
Other: Placeholder image looks better on wider editors. Closes #63.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-upload Oct 9, 2019
@mlewand mlewand added this to the iteration 12 milestone Oct 9, 2019
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. package:upload labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonkups szymonkups

Labels
package:upload type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 12
Development

Successfully merging a pull request may close this issue.

Image placeholder styling ckeditor/ckeditor5-upload
2 participants
@szymonkups @mlewand