Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rect constructor should accept a function as a source #4954

Closed
oleq opened this issue May 16, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-utils#158
Closed

Rect constructor should accept a function as a source #4954

oleq opened this issue May 16, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-utils#158
Assignees
@oleq
Labels
package:utils type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 11

Comments

@oleq
Copy link
Member

oleq commented May 16, 2017

A follow-up of https://github.com/ckeditor/ckeditor5-ui/issues/227 and https://github.com/ckeditor/ckeditor5-ui/issues/195.
@oleq oleq self-assigned this May 16, 2017
@Reinmar
Copy link
Member

Reinmar commented May 16, 2017

Isn't rect immutable? Why is rect supposed to watch for changes? There's no explanation in neither of these tickets.

@oleq
Copy link
Member Author

oleq commented May 16, 2017 •
edited
Loading

@Reinmar Please read the PR first. Rect will not watch anything, it's simply a matter of providing a function that returns the source of the Rect, once, in the constructor.

oleq referenced this issue in ckeditor/ckeditor5-utils May 17, 2017
@oleq
Other: getOptimalPosition utility should accept the target option
01b8684 
defined as a function. Closes #157.
oskarwrobel referenced this issue in ckeditor/ckeditor5-utils May 17, 2017
@oskarwrobel
Merge pull request #158 from ckeditor/t/157
d63abae 
Other: `getOptimalPosition` utility should accept the target option defined as a function. Closes #157.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-utils Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:utils labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:utils type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

t/157: getOptimalPosition should accept a target defined as a function ckeditor/ckeditor5-utils
3 participants
@Reinmar @oleq @mlewand