Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks if there are more then X crashes in less then Y minutes #4697

Closed
pjasiun opened this issue Jul 4, 2019 · 3 comments · Fixed by ckeditor/ckeditor5-watchdog#16
Closed
Assignees
Labels
package:watchdog type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone

Comments

@pjasiun
Copy link

pjasiun commented Jul 4, 2019

Now watchdog simply checks if there are X crashes and do not restart anymore if there are more then X crashes, to prevent infinite restart loops. Instead, it could check if there are more than X crashes in less then Y minutes (for instance stop restarting if there are more than 3 crashes in less then 10 minutes). WDYT?

@pjasiun pjasiun changed the title Checks if there are X crashes in less then Y minutes Checks if there are more then X crashes in less then Y minutes Jul 4, 2019
@Reinmar
Copy link
Member

Reinmar commented Jul 8, 2019

Agree. I found this a bit odd that any 3 crashes disable the watchdog.

@mlewand
Copy link
Contributor

mlewand commented Jul 8, 2019

Also the number of handled crashes should be slightly increased. 3 seems just slightly too little, my reasoning is based on a following case:

Assume that end-user uses a broken feature.

If I was end user after getting a first restart I'd instantly attempt second try (thinking that maybe something weird happened). There's a good chance the user will also make third try, which will bail out graceful editor restart.

@ma2ciek
Copy link
Contributor

ma2ciek commented Jul 8, 2019

Note that this option is also configurable. But I agree that we can increase the default value a bit and change the logic to catch a specific number of errors in some time period.

@ma2ciek ma2ciek self-assigned this Jul 31, 2019
pjasiun referenced this issue in ckeditor/ckeditor5-watchdog Aug 2, 2019
Feature: Introduced the observable `Watchdog#state` property. Introduced the `minimumNonErrorTimePeriod` configuration which defaults to 5 seconds and will be used to prevent infinite restart loops while allowing a larger number of random crashes as long as they do not happen too often. Renamed `waitingTime` configuration option to `saveInterval`. Closes #7. Closes #15.

BREAKING CHANGE: Renamed `waitingTime` configuration option to `saveInterval`.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-watchdog Oct 9, 2019
@mlewand mlewand added this to the iteration 26 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:watchdog labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:watchdog type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants