Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PFO] Filtering Word-related and superfluous styles and classes #10956

Closed
Reinmar opened this issue Dec 6, 2021 · 4 comments
Closed

[PFO] Filtering Word-related and superfluous styles and classes #10956

Reinmar opened this issue Dec 6, 2021 · 4 comments
Labels
resolution:resolved This issue was already resolved (e.g. by another ticket). squad:core Issue to be handled by the Core team. status:stale type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@Reinmar
Copy link
Member

Reinmar commented Dec 6, 2021

Part of #10577.

  • Order of processing the content
    1. inline stylesheets
    2. normalization (lists, images, etc)
    3. filter word-related and superfluous content (has to be done after normalization because normalization may require this information)
    4. inline block styles to text
  • Scope:
    • Review existing CKE4's implementation for what needs to be removed. You can find these things also in the original PoC, but that implementation was rather poor.
    • Mso* classes.
    • <span style="mso-ansi-language:PL;" lang="PL">Bar</span> if the language is different than [editor.language.content](<https://ckeditor.com/docs/ckeditor5/latest/api/module_core_editor_editorconfig-LanguageConfig.html#member-content>) (it may require some smarter comparison method because of different language name formats).
@Reinmar Reinmar added type:task This issue reports a chore (non-production change) and other types of "todos". squad:core Issue to be handled by the Core team. labels Dec 6, 2021
@wimleers
Copy link

Also reported over in Drupal 9.3: https://www.drupal.org/project/drupal/issues/3254346

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Oct 30, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
@Reinmar
Copy link
Member Author

Reinmar commented Nov 2, 2023

This issue was actually resolved with #14925.

@Reinmar Reinmar added resolution:resolved This issue was already resolved (e.g. by another ticket). and removed resolution:expired This issue was closed due to lack of feedback. labels Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:resolved This issue was already resolved (e.g. by another ticket). squad:core Issue to be handled by the Core team. status:stale type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

3 participants