Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammarly deletion suggestion doesn't work on all browsers #14278

Open
Witoso opened this issue May 30, 2023 · 9 comments
Open

Grammarly deletion suggestion doesn't work on all browsers #14278

Witoso opened this issue May 30, 2023 · 9 comments
Labels
browser:chrome browser:firefox browser:safari domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Witoso
Copy link
Member

Witoso commented May 30, 2023

📝 Provide detailed reproduction steps (if any)

  1. Visit the https://ckeditor.com/docs/ckeditor5/latest/examples/builds/classic-editor.html
  2. Make sure Grammarly is enabled.
  3. Write a sentence "I am a a developer".
  4. Try to delete duplicated a.

✔️ Expected result

The word a is deleted.

❌ Actual result

The word a is not removed.

📃 Other details

  • Browser: Chrome/Firefox/Safari

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@Witoso Witoso added type:bug This issue reports a buggy (incorrect) behavior. domain:ui/ux This issue reports a problem related to UI or UX. browser:chrome browser:firefox browser:safari squad:core Issue to be handled by the Core team. domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). labels May 30, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Aug 7, 2023
@mmotyczynska mmotyczynska self-assigned this Sep 1, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Sep 1, 2023
@mmotyczynska
Copy link
Contributor

The only event fired by Grammarly in this case (deletion suggestion) is keydown. This is not enough to handle it properly in CKEditor. We would expect beforeinput. As Grammarly has integration with CKEditor 5, we could ask them to improve it for browser extensions by firing additional event.

@mmotyczynska
Copy link
Contributor

BTW, the integration using grammarly-editor-plugin web component works well, so what we'd expect is to modify browser extensions so they work similarly to Grammarly Text Editor SDK.

@Witoso
Copy link
Member Author

Witoso commented Sep 7, 2023

The error message suggests this is an upstream problem with the Grammarly extension.

As there's an error for a specific integration, we should reach out to them.

@blacktaxi, as you participated in #267, could you pass the message, or let us know what's the best contact method for such issue?

@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 8, 2023
@Witoso
Copy link
Member Author

Witoso commented Sep 11, 2023

Hmm, it magically started working? 😀 Testing Chrome on Mac, and it deletes the example that didn't work before...

Screen.Recording.2023-09-11.at.09.57.40.mov

@mmotyczynska could you check? The Firefox though still works bad for replacement (rel: #14259)

Screen.Recording.2023-09-11.at.10.00.18.mov

@mmotyczynska
Copy link
Contributor

@Witoso Unfortunately, it still doesn't work. The case you've just tested is not about deletion, but changing the verb form. The original one was in the first image caption, not the second (for some reason Grammarly does not mark it anymore).
Anyway, a simple sentence I use to test deletion is "I am a a developer" where one "a" should be deleted.

@Witoso
Copy link
Member Author

Witoso commented Sep 11, 2023

Yep, there are two different videos, and fixing the first caption works (I think because it's an improvement), but I confirm that the "I am a a developer" doesn't.

@Witoso
Copy link
Member Author

Witoso commented Sep 11, 2023

I created a support request: #6307989.

@Witoso
Copy link
Member Author

Witoso commented Sep 27, 2023

Posting the first reply for transparency.

Unfortunately, we don’t currently have a quick fix, but we have logged the issue and notified our product team. I can’t provide you with an estimated timeframe right now because the developers need some time to analyze the cause of the issue.
 
In the meantime, we recommend that you use Grammarly for Mac, which integrates with multiple applications and websites. This app appears as a floating widget when you start typing and a Grammarly icon in the menu bar located at the top of your screen.

I've just sent them a follow-up ping.

@godai78
Copy link
Contributor

godai78 commented Jan 22, 2024

On a side note: Grammarly suggestion replacements can pretty badly trash reddit edit area, too. So that might be a larger problem.

@mmotyczynska mmotyczynska removed their assignment Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:chrome browser:firefox browser:safari domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants