Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ckeditor5-dev-ci: triggerCircleBuild() does not throw when could not trigger a new pipeline #16746

Closed
pomek opened this issue Jul 17, 2024 · 0 comments · Fixed by ckeditor/ckeditor5-dev#978
Closed

ckeditor5-dev-ci: triggerCircleBuild() does not throw when could not trigger a new pipeline #16746

pomek opened this issue Jul 17, 2024 · 0 comments · Fixed by ckeditor/ckeditor5-dev#978
Assignees
@martnpaneq
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 76 (v43...

Comments

@pomek
Copy link
Member

pomek commented Jul 17, 2024

📝 Provide detailed reproduction steps (if any)

In short, the response from CircleCI when it could not create a new pipeline looks like this:

image

While our tools check the error_message property. For backward compatibility, I would check both keys.
@pomek pomek added type:bug This issue reports a buggy (incorrect) behavior. squad:platform Issue to be handled by the Platform team. package:dev labels Jul 17, 2024
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jul 17, 2024
@martnpaneq martnpaneq self-assigned this Jul 18, 2024
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Jul 18, 2024
@martnpaneq martnpaneq mentioned this issue Jul 18, 2024
Merged
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jul 18, 2024
@CKEditorBot CKEditorBot added this to the iteration 76 milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martnpaneq martnpaneq

Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 76 (v43.0.0)
Development

Successfully merging a pull request may close this issue.

Improved error handling for triggerCircleBuild(). ckeditor/ckeditor5-dev
3 participants
@pomek @CKEditorBot @martnpaneq