Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested item gets focused in menu bar after clicking category button #16857

Closed
scofalik opened this issue Aug 5, 2024 · 5 comments · Fixed by #16980
Closed

Nested item gets focused in menu bar after clicking category button #16857

scofalik opened this issue Aug 5, 2024 · 5 comments · Fixed by #16980
Assignees
Labels
package:ui squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@scofalik
Copy link
Contributor

scofalik commented Aug 5, 2024

📝 Provide detailed reproduction steps (if any)

Screen.Recording.2024-08-05.at.11.16.50.mov

After clicking the "category" button like "Image", or "Text", the first item inside gets focused and stays focused. Earlier we decided to show focus only on keyboard interaction.

@scofalik scofalik added type:bug This issue reports a buggy (incorrect) behavior. package:ui squad:collaboration Issue to be handled by the Collaboration team. labels Aug 5, 2024
@Mati365
Copy link
Member

Mati365 commented Aug 7, 2024

@scofalik It's not entirely a bug. From what I remember, it handles case when user press arrow down after clicking menu. Without such focus selection, it's kinda hard for the user to distinguish which menu item should be highlighted - parent menu item or nested menu item.

@scofalik
Copy link
Contributor Author

scofalik commented Aug 7, 2024

It might be the case, probably to be discussed then.

@Mati365
Copy link
Member

Mati365 commented Aug 7, 2024

@scofalik Yep, it's not super intuitive, though. Probably needs adjustments. So it'll be better to keep this issue open.

@oleq
Copy link
Member

oleq commented Aug 14, 2024

We discussed this topic and we figured out the best solution would be no action upon clicking a menu category button, no focus movement, no outline change (unless it violates WCAG).

@Comandeer
Copy link
Member

It shouldn't violate WCAG as a focus indicator is needed only for keyboard navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ui squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants