Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One of the basePath tests fails on Firefox #20

Closed
gregpabian opened this issue Apr 15, 2015 · 4 comments
Closed

One of the basePath tests fails on Firefox #20

gregpabian opened this issue Apr 15, 2015 · 4 comments
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@gregpabian
Copy link
Contributor

A test called "basePath should work with script tags - \ckeditor\ckeditor.js" fails on Firefox. Tested with FF version 37.0.1.

@gregpabian gregpabian added the type:bug This issue reports a buggy (incorrect) behavior. label Apr 15, 2015
@fredck
Copy link
Contributor

fredck commented Apr 15, 2015

That's because change the script URL to: http://localhost:1030/tests/ckeditor/%5Cckeditor%5Cckeditor.js

...while in Chrome we have this:
http://localhost:1030/ckeditor/ckeditor.js

@Reinmar, you added this test... what's the sense of it?

@Reinmar
Copy link
Member

Reinmar commented Apr 15, 2015

You mean this test https://github.com/ckeditor/ckeditor5/blob/master/tests/ckeditor/basepath.js#L23?

It checks if we can find ckeditor.js path even if it's loaded from Windows file system.

@fredck
Copy link
Contributor

fredck commented Apr 16, 2015

You mean this test https://github.com/ckeditor/ckeditor5/blob/master/tests/ckeditor/basepath.js#L23?

Yes.

I've been trying to change this test, while keeping the same scope, but I got no luck. The point is that that one is not a valid URL for file system stuff and I'm afraid that it will be impossible to run that test in Firefox... maybe on Windows systems only.

Can we remove that test? Or maybe make it a regression for Firefox (non Windows?) only?

@Reinmar
Copy link
Member

Reinmar commented Apr 16, 2015

The code would need to be changed to be testable, not the test. I'm ok with removing that test (or leaving it commented for the future, so it's clear what else must work).

@fredck fredck closed this as completed in 35a79f0 Jun 12, 2015
@Reinmar Reinmar modified the milestone: 0.1.0 Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants