Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table cell view post-fixer crashes when element was changed and removed #3273

Closed
scofalik opened this issue May 20, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-table#192
Closed

Table cell view post-fixer crashes when element was changed and removed #3273

scofalik opened this issue May 20, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-table#192
Assignees
@scofalik
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 24

Comments

@scofalik
Copy link
Contributor

Related to https://github.com/ckeditor/ckeditor5-table/issues/187.

In short, when a view element which is inside a table gets or has an attribute removed (or the model element was renamed), the view post-fixer will want to perform some action on view element bound to it.

However, if the model element was also removed, the model and view elements will not be mapped anymore, which causes a crash in the post-fixer.

Post-fixer should not fire for view elements which are removed.
@scofalik scofalik self-assigned this May 20, 2019
pjasiun referenced this issue in ckeditor/ckeditor5-table May 20, 2019
Merge pull request #192 from ckeditor/t/191
900c178 
Fixed: Table cell view post-fixer will not crash if an element inside a cell got attribute and was removed at the same time. Closes #191.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the iteration 24 milestone Oct 9, 2019
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:table labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 24
2 participants
@scofalik @mlewand